Mastercraft and speed buff still not implemented for RC [r 875]

Support Resolved Reports
1

Recently I’ve started playing Rayya’s Children faction and noticed that some of the town bonuses aren’t implemented.

Mastercraft bonus doesn’t work for RC. I can very often craft a masterwork item as Ascendancy while as RC I’ve crafted THOUSANDS and haven’t got a single mastercrafted item. I’ve compared the files for Ascendancy and RC - and it looks that Masterwork code is missing for RC, regardless of the quest bonus descriptions.

Same goes for x3 road speed buff - all RC move as fast as Ascendancy without the speed buff, while AC WITH the speed buff are significantly faster than RC. I haven’t checked the files, but I’ve tested it in-game with friends and it’s very obvious when playing Multiplayer…

I wonder if Northern Alliance lacks the same bonuses as RC…

2

Ascendancy:

image
image.png1143×670 42 KB

Rayya’s Children:

image
image.png1193×365 23.7 KB

Northern Alliance:

image
image.png1205×362 23.3 KB

I’ve tried manually adding the bonuses to RC by copying the code, but it didn’t work… Maybe I did sth wrong…

3

I assume you did this, but just to check, did you change the “class” function prefix to be the same as the destination? i.e., when copying over

function GuildmasterTownBonus:get_adjusted_item_quality_changes()

to Rayya’s Children, did you change it to this?

function RcGuildmasterTownBonus:get_adjusted_item_quality_changes()
4

Yeah, at the first time I didn’t notice that “Rc” at the beginning of the function name, but then I changed it properly, ordered 60 pcs of equipment and still got none of Masterwork quality, while as Ascendancy I get about 1 of every 10 pcs crafted.

5

Good catches.

For masterwork crafting, those files are fine (they inherit from the Ascendancy one), but the code that calls the function was looking specifically for the Ascendancy town buff, which is now fixed in the next release.

For roads, it isn’t Ascendancy vs other races. The problem was that roads built in the new building editor don’t have the bonus applied until after a reload. This is also fixed in the next release.

4 Likes
6

Well… the code still looks the same, regardless of the new updates…
Can I add it manually?

7

The files involved in the change are cunning_town_bonus.lua and crafter_component.lua. Note that if you have unpacked the SMODs, Steam won’t update the unpacked ones.