Uncategorized Items and missing icons in town inventory

Minor bug, see screenshots:

As you can see, neither item is in a proper category, and they are missing icons as well.

3 Likes

The carpenter’s saw is missing an icon as well, i don’t even get a placeholder for it:

4 Likes

I’ve seen items that don’t have an icon, but as soon as I close and reopen the menu, do have an icon.

1 Like

Picture is best on how to describe, first, ensure you have a few Basket of Turnips in your Stockpile. Then look at Town Info -> Town Overview

https://b3nw.box.com/shared/static/zas6iwa1kchj0qa3bd6i.png

1 Like

The shephards crook, appears to have no icon or category.

3 Likes

I add 2 more tools in the wrong case…

Alpha 9 Build 256.

1 Like

Seems to be the case still (R375), at least for the wooden shield. See attached video at 34:40.

3 Likes

In order to be properly added to a category, an item’s iconic.json file needs to have a category line in it’s item component. If it doesn’t it appears as uncategorized. One day we will write a script to check for this! In the meantime, please keep calling these guys out. :slight_smile:

8 Likes

As of r-393, this still applies to all armor (at least, all the armor/vests the weaver can craft) and to wooden shields.

3 Likes

Found a couple of things that are uncategorized. Looks like the Farmer’s Hoe is not a tool and the Big Wall-Mounted Banner is not a decoration.

1 Like

@druha - Thanks! Both the big and small banner will be fixed. That particular version of the farmer’s hoe shouldn’t be in your game. It appears to be dropped accidentally from a farmer that was killed instead of being crafted by the carpenter?

1 Like

hmmm interessting ^^ sometimes the category is in the talisman and sometimes in the iconic ^^

but for example the blacksmith-hammer and the chisel has it in the talisman and the hoe in the iconic ^^

1 Like

Right! For talismans, it should be in the talisman file. It can be in the iconic one too, but the talisman file is the important one. Good eye :slight_smile:

1 Like

I haven’t had anyone die in that world yet. Nor have I traded for or bought any hoes. That was crafted by my Carpenter.

1 Like

Ok. Thanks for the info!

2 Likes

ok then its missing in the saw, the hoe, the shepherd crook, trapper knife and the spindle ^^ the other has only a tag and ?an itemstack info? -.- i think the stackinfo can be replaced with the category xD

only the mason chisel, the blacksmith hammer and the wooden sword has a cate

@druha i can confirm this :wink:

2 Likes

ok i have check the entities and im confused ^^ sometimes there are a “category” in the iconic and sometimes not xD like all armors have the category in the normal json and not in the iconic - at the decorations its switched xD

so just for info the armors has no category in the iconic, also the plushie toy rabbit, the jagged cleaver, the skull trophy, the tombstone (sry i must say this because you can get them in your stockpile xD), the throw rug, the gilded crimson

the campbanner hasnt it also but there is no need for it xD

just for info: i have checked the big and small banner in then the categorys was in the json instead of the iconics - and because of this i give this info xD

i hope i could help again :wink:

3 Likes

Going forward, the category will be on both the normal and iconic entity. Currently, the code only uses the form of the entity that is placed in the stockpile, that is, it uses the iconic entity if there is one defined, otherwise it uses the normal entity.

I just fixed the categories for all the armor and weapons. Eventually, we’ll have a tool that validates all the entities so we don’t continue to have json files that are inconsistent.

6 Likes

When that happy day comes, could you make sure it can validate everything? Specifically, I’m thinking of sell price.

Yep. That’s the plan. It will also flag / correct any issues with the model_origin, region_origin, region_collision_shape, and destination regions, that are hard to get right.

3 Likes