[r166] Bad Wall Placement Crashes Game

Support Previous Build Reports
1

Summary:
Shift+Clicking out of terrain bounds while building wall results in game crash,

Steps to Reproduce:
Start building a wall on flat ground, Extend wall by Shift+Clicking portions. If the shift+Click takes place on invalid terrain (say, a cliff face instead of the cliff edge), the game crashes.

Expected Results:
Either nothing happens, or the game gives a warning dialogue for invalid placement.

Actual Results:
Game crashes without error log or save.

Screenshots:
First crash:

Screenshot 2014-12-02 17.28.35.png1920Ă—1080 609 KB

First Reproduction: I suppose the game found something on the same Z-plane/vertical height to place it? Though following this none of the buttons or Esc worked.

Screenshot 2014-12-02 17.26.45.png1920Ă—1080 490 KB

Second reproduction: I have drawn a red circle to show where the shift+click took place to produce the crash.

Screenshot 2014-12-02 17.28.35.png1920Ă—1080 615 KB

Edit: I’m aware this is sort of a funny issue to point out because I’m not supposed to be clicking there in the first place. However, it began with an accident and the resulting crash meant lost progress, and I was able to reproduce it.

4 Likes
2

Confirmed, log file keeps repeating the same Lua error hundreds of times (the original file is actually too big to upload…).

stonehearth.log.txt (Truncated log file 24.6 KB)

3

This still occurs in version 180, but the specific crash has changed. Instead of hanging in an infinite loop, it now just crashes straight to desktop with the following lua error in the log:

2014-Dec-18 02:45:08.822930 | client | 1 | lua.code | generating traceback…
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | – Script Error (lua) Begin -------------------------------
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | std::exception: 'bad allocation’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | stack traceback:
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | [C]: at 0x009101a0
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | [C]: in function 'is_valid_standing_region’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | …earth/services/client/build_editor/wall_loop_editor.luac:67: in function '_fit_point_to_constraints’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | …earth/services/client/build_editor/wall_loop_editor.luac:21: in function '_progress_cb’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | …ehearth/services/client/selection/location_selector.luac:23: in function 'notify’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | …ehearth/services/client/selection/location_selector.luac:90: in function '_on_mouse_event’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | …ehearth/services/client/selection/location_selector.luac:127: in function '_dispatch’
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | stonehearth/services/client/input/input_service.luac:7: in function <stonehearth/services/client/input/input_service.luac:4>
2014-Dec-18 02:45:08.823932 | client | 0 | lua.code | – Lua Error End -------------------------------
2014-Dec-18 02:45:08.823932 | client | 1 | client | error dispatching input: lua runtime error
2014-Dec-18 02:45:08.824932 Fatal Exception.
2014-Dec-18 02:45:08.824932 Total System Memory: 7.984 GB (8572227584 bytes)
2014-Dec-18 02:45:08.824932 Current Memory Usage: 1.667 GB (1789902848 bytes)
2014-Dec-18 02:45:08.824932 Total Address Space: 2.000 GB (2147352576 bytes)
2014-Dec-18 02:45:08.824932 Available Address Space: 8.105 MB (8499200 bytes)
2014-Dec-18 02:45:08.824932 Used Address Space: 1.992 GB (2138853376 bytes)