Missing key in en.json, please verify

Hi @yshan

I’m translating the game in French (French translation (via github.com/stonehearth/startermod_locale))

Can you please check that you have not forgotten this key (supposed name) in en.json :

stone_tunnel_door_recipe
clay_tunnel_door_recipe

1 Like

already mentioned from me :wink: also the links for the wooden_tunnel_door ghost are not correct - it shows to the 4x4 door ^^

but thx for reposting xD

@yshan can you help :wink: :heart: :heart::heart:

1 Like

Hi,
the starter mod locale’s en.json is not always up to date with latest a15. If you grab the en.json from the a15 stable release, it will have those 2 keys.
Also, the wooden tunnel door ghost does have the key set as wooden_door_4x4. It will behave correctly, it’s just that the string key’s path doesn’t exactly match the name of the door, which is a bummer and I will fix it now, but note that the important thing is to translate from the english string, not the string key. The string key can be whatever anyone sets it to be, so it is not something to be focused on.
Thanks
-Yang

2 Likes

Actually, I cannot change the key for the wooden tunnel door because it will break the names for existing doors. :frowning:
So yeah, gonna have to live with that. It’s because that door’s folder used to be named wooden_door_4x4 so the auto loc key generator has that string in there. Sorry!
-Yang

1 Like

@Wiese2007 @yshan thx !

I dont understand why we are talking about wooden door.

In the last steam branch, en.json contains :
ITEM :
“wooden_tunnel_door_ghost”: {
“display_name”: “Wooden Tunnel Door”,
“description”: “Useful for blocking off tunnels”
}
“stone_tunnel_door”: {
“stone_tunnel_door_ghost”: {
“display_name”: “Stone Tunnel Door”,
“description”: “Useful for sealing off mine tunnels.”
}
},
“clay_tunnel_door”: {
“clay_tunnel_door_ghost”: {
“display_name”: “Clay Tunnel Door”,
“description”: “Useful for sealing off mine tunnels”
}
}

RECIPE :
“wooden_tunnel_door_recipe”: {
“recipe_name”: “Wooden Tunnel Door”,
“description”: “Useful for blocking off tunnels”
},

: (

1 Like

in the latest version arent the string for the recipes stone and clay tunnel_door - only the ghosts ^^

shouldnt it be easy to change this? at first in the ghost from

stonehearth:entities.construction.wooden_door_4x4.wooden_tunnel_door_ghost to stonehearth:entities.construction.wooden_tunnel_door.wooden_tunnel_door_ghost and then add in the en.json just the missing foldername

“wooden_tunnel_door”: {
“wooden_tunnel_door_ghost”: {
“display_name”: “Wooden Tunnel Door”,
“description”: “Useful for blocking off tunnels”
}

little info there: you can remove the string for 4x4 door because this door doesnt exist and the wooden_tunnel_door was at first named 4x4 door ^^

and in my test it works without any issues ^^


all names shown correct and no ui errors or other issues and thats also with my translation xD ^^

if you want i can send you the corrected files? ^^

1 Like

@Wiese2007 I can change the string but I would have to keep the old string key in en.json for save compatibility.

Try creating a save with the old door string key and then loading up the save after your changes. The old door will no longer have a name …

Thanks,
-Yang

ok thats correct ^^ in old saves its missing then because this string doesnt exist anymore xD then i will change the string info of the 4x4 to wooden door xD

then i will add this info to my list for other translators :wink:

Going back to my problem, I compared a translatable recipe to a recipe that causes me a problem:

stonehearth\jobs\mason\recipes\stone_table_recipe.json
"recipe_name": “i18n(stonehearth:jobs.mason.recipes.stone_table_recipe.recipe_name)”,
“description”: “i18n(stonehearth:jobs.mason.recipes.stone_table_recipe.description)”,

stonehearth\jobs\mason\recipes\stone_tunnel_door_recipe.json
"recipe_name": “Stone Tunnel Door”,
“description”: “Useful for sealing off mine tunnels.”,

Conclusion : the text is hard coded, no translation possible.

1 Like

Oh I see, the recipe names are missing. Okay, I will fix. thanks for the heads up!
-Yang

2 Likes

ok mainissue resolved xD

sry for the little distraction xD

1 Like