Tiny bug related to logging


#1

Summary: If your stonehearth log_level in user_settings.json is set to at least 5, you’ll get a Lua error when a hearthling dies, due to an incorrectly configured string in a log:info(...) call.

Steps to reproduce:

  1. Set your stonehearth log_level in user_settings.json to at least 5
  2. Kill a hearthling
  3. Experience Lua error

Notes: It’s stonehearth/services/server/town/town.lua line 409:
Current: self._log:info('removing %d from task group "%s"', entity, task_group_uri)
Should be: self._log:info('removing %s from task group "%s"', entity, task_group_uri)

Not a critical thing, just annoying for modders trying to debug their own stuff and trying to track down why this error is happening. :stuck_out_tongue:


#2

Also stonehearth/services/client/sound/sound_service.lua line 363.


#3

This one’s already an %s :thinking:


#4


#5

That one causes a nil value formatting error when I launch the game.