There is two ways to generate the trees. One of them are from another random map generator, but instead of generating elevations for the terrain, it generates the vegetation sizes. That’s that part in the code where you select the sizes of trees based on a score (0 and up for small, 10 and up for medium, 18 and up for large, etc…).
The other way is like any other object, randomly placed around. Deserts do this with trees, while temperate do both.
But there is also some hard coded things in Lua, like berries can’t generate on mountains, there is a specific line I just saw that checks for it, if terrain = mountain (or plains holes), don’t generate berries, lol No idea why limit it in Lua though.
It was an error with Line 228 in the biome lua (looking into it now). In the mean time I’ve just been using the 1 1 1 with the recolor as you described
Edit: That error seemed to be caused by a bad base height. The new error is line 400 in the landscaper
Yeah I fixed the height, but still got the landscaper error. I’ve decided to just stick with Step Count 2 for the time being, since the dirt patches are so infrequent. But if you manage to make a file that has a valley count of 2 (so not requiring a recolor fix) let me know. The other issue I was having with the recolor fix was that I simply couldn’t get berries to ever spawn in plains (because they were being treated as dirt).
From a quick test yes, I tested around 10 seeds and none had them and no errors when embarking. Maybe it was just luck? I still didn’t got this valley_count figured out.
From what I can extract from the biome lua, it seems like setting the valley count to 2 makes the height_valley equal to the height_max (normally 2 lower)?
Everything was written in Lua prior to Rayya’s Children release. With that, they introduced the JSON model. So desert generation uses the latest Radiant-preferred way to generate the biome (via JSON), while the temperate model has not yet been updated thoroughly and is using some old sections of code that they didn’t replace for whatever reason.