Potter's workshop view is missing its open sound effect

Summary: When opening the Potter’s workshop, there is no ‘workshop opening’ sound effect that normally plays when a workshop is opened. By ‘workshop’ I mean ‘StonehearthTeamCrafterView’.

Steps to reproduce:

  1. start a game
  2. promote a hearthling to be a potter
  3. open the potter’s workshop via the game menu, selected potter’s unit frame ‘show workshop’ button, or via selected kiln/wheel item ‘show workshop’ button

Expected Results:
The opening workshop sound effect is played

Actual Results:
No sound effect is played and an error appears in the CEF/javascript debugger tools console:

error message / stack trace POST http://radiant/r/call/?fn=radiant:play_sound 500 (ERROR) jquery-1.10.2.min.js:6 x.ajaxTransport.send jquery-1.10.2.min.js:6 x.extend.ajax object.js:180 SimpleClass.extend._docall object.js:232 radiant.callv object.js:251 radiant.call show_team_workshop.js:57 (anonymous function) ember-1.8.1.min.js:5 w ember-1.8.1.min.js:4 m ember-1.8.1.min.js:5 b ember-1.8.1.min.js:5 a ember-1.8.1.min.js:5 h ember-1.8.1.min.js:5 a ember-1.8.1.min.js:5 y ember-1.8.1.min.js:8 p.default._.create.set view.js:140 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) trace.js:180 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) trace.js:210 SimpleClass.extend._expand_object_properties.notify_update trace.js:253 SimpleClass.extend._expand_object_properties.$.each.update_property trace.js:258 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) trace.js:180 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) trace.js:210 SimpleClass.extend._expand_object_properties.notify_update trace.js:253 SimpleClass.extend._expand_object_properties.$.each.update_property trace.js:258 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) trace.js:296 SimpleClass.extend._expand_array_properties.notify_update trace.js:314 SimpleClass.extend._expand_array_properties.$.each.update_property trace.js:319 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) trace.js:180 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.add trace.js:178 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) object.js:47 (anonymous function) underscore-1.5.2.js:79 _.each._.forEach object.js:46 (anonymous function) object.js:57 SimpleClass.extend._protect traceList object.js:45 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) object.js:144 SimpleClass.extend.init.$.ready.foward_fn jquery-1.10.2.min.js:5 x.event.dispatch jquery-1.10.2.min.js:5 x.event.add.v.handle jquery-1.10.2.min.js:5 x.event.trigger jquery-1.10.2.min.js:5 (anonymous function) jquery-1.10.2.min.js:4 x.extend.each jquery-1.10.2.min.js:4 x.fn.x.each jquery-1.10.2.min.js:5 x.fn.extend.trigger object.js:165 (anonymous function) jquery-1.10.2.min.js:4 x.extend.each object.js:164 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:4 x.extend.Deferred.x.each.i.(anonymous function) object.js:192 (anonymous function) jquery-1.10.2.min.js:4 x.Callbacks.c jquery-1.10.2.min.js:4 x.Callbacks.p.fireWith jquery-1.10.2.min.js:6 k jquery-1.10.2.min.js:6 x.ajaxTransport.send.r
image of same stack trace

Notes:
Playing as Rayya’s Children.
Sound effects for ‘show workshop’ are working correctly for mason and weaver – have not tested with classes other than potter, weaver, and mason.

Attachments:

Version Number and Mods in use:
Alpha 18, release-663

System Information:
n/a

2 Likes

Thanks for the report! A fix will be going into the next build.

1 Like